Core/Unit: Fix removal of auras on evade issues #14771
Conversation
|
Kilyana is testing it now to check the if validity covers all cases |
| Aura const* aura = aurApp->GetBase(); | ||
|
|
||
| if (!aura->IsPassive() && !aurApp->IsPositive() // all negative, non - passive auras, | ||
| && !(aura->GetSpellInfo()->AttributesEx3 & SPELL_ATTR3_DEATH_PERSISTENT) && // non death-persistent |
There was a problem hiding this comment.
!aura->GetSpellInfo()->HasAttribute(SPELL_ATTR3_DEATH_PERSISTENT)
|
It fix the issue as intended but in some cases like Festergut and Putricide the auras are not removed after a reset. EDIT: Fixed, auras are now removed on rest |
| SPELL_ATTR3_REQ_OFFHAND = 0x01000000, // 24 Req offhand weapon | ||
| SPELL_ATTR3_UNK25 = 0x02000000, // 25 no cause spell pushback ? | ||
| SPELL_ATTR3_CAN_PROC_WITH_TRIGGERED = 0x04000000, // 26 auras with this attribute can proc from triggered spell casts with SPELL_ATTR3_TRIGGERED_CAN_TRIGGER_PROC_2 (67736 + 52999) | ||
| SPELL_ATTR3_DRAIN_SOUL = 0x08000000, // 27 only drain soul has this flag | ||
| SPELL_ATTR3_UNK28 = 0x10000000, // 28 | ||
| SPELL_ATTR3_ENRAGE = 0x10000000, // 28 flag used for creature enrage abilities (61632,26662 for example) |
There was a problem hiding this comment.
i dont think so. http://paste2.org/I2I2whck
|
probably a method to get the Enrage spells should be implemented, or a way to call this with a parameter from bosses (@MitchesD add your thoughts) |
|
@mik1893 |
|
Attributes: 0x20000100 (SPELL_ATTR0_HIDE_IN_COMBAT_LOG, SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY) it's should be removed on both cases, but it's an exception. It's difficult to find a common rule for this, the only way i think about is that this behaviour should be applied when it's a non-boss creature, and bosses just gets all auras removed on evade (like it was before basically). I will try to make a more generic solution for this |
|
According to this video https://youtu.be/IzPe9MeaUU4?t=4m11s the aura persist after death. |
|
ok so this aura is missing the attribute DEATH_PERSISTANT. |
|
for the removal on evade, this is an exception and should be handled in boss spellscript |
| @@ -407,7 +407,7 @@ enum SpellAttr3 | |||
| SPELL_ATTR3_DEATH_PERSISTENT = 0x00100000, // 20 Death persistent spells | |||
| SPELL_ATTR3_UNK21 = 0x00200000, // 21 unused | |||
| SPELL_ATTR3_REQ_WAND = 0x00400000, // 22 Req wand | |||
| SPELL_ATTR3_UNK23 = 0x00800000, // 23 | |||
| SPELL_ATTR3_UNK23 = 0x00800000, // 23 | |||
|
some auras on sindragosa arent removed too (must check for raid mode entries) |
|
someone has to check at least every bossfight and check the remove of the auras on evade |
|
confirm this problem in lanathel too |
|
I don't know if it's possible to do: removing auras that result from spells casted during the combat, this will fix all the issues. |
|
i'm thinking.... i don't think there's a way to get spells casted during combat, but we might add a property for this |
|
I added a property on aura to know if it was added on spawn from creature_addon |
|
"removing auras that result from spells casted during the combat" that should be check, is it ALWAYS that behaviour correct? |
|
Yes when a npc evade he must loose all the auras except the ones set on spawn, of course for pets and guardians all the aura must remain (but still need confirmation) |
|
a pet or guardian never goes in evade, actually, so it wont be a problem |
|
For Pet it's fine, but we need to fix the guardians. |
|
ok, this should be definitive. please test it! |
|
On a recent commit (I cannot find it) Auras from Creature_addon are no longer removed on evade, still in some cases when the aura is set on spawn with SAI, must be fixed on DB by changing the event on reset or moving the aura to the creature_addon. But for the guardians issue it must be fixed as they loose auras on evade, I opened this issue for guardians when the evade issue wasn't fixed for auras from creature_addon so thought it was related. This commit changes nothing to the actual behavior, sorry for the wasted time. |
|
not needed anymore |
closes #14347